KEMBAR78
Update the SPDX-License-Identifier for Ryu-derived sources by StephanTLavavej · Pull Request #5401 · microsoft/STL · GitHub
Skip to content

Conversation

@StephanTLavavej
Copy link
Member

Fixes #5397.

I am neither a lawyer nor a cat, and this is not a licensing change. It is simply clarifying our machine-searchable SPDX-License-Identifier to align with our original intentions.

Most of our source files are available under the Apache License v2.0 with LLVM Exception, chosen to match libc++. Our <charconv> implementation was derived from the ulfjack/ryu repo's ryu/ subdirectory, which is dual-licensed. Quoting that repo's README:

All code outside of third_party/ is copyrighted by Ulf Adams and contributors, and may be used freely in accordance with the Apache 2.0 license. Alternatively, the files in the ryu/ directory may be used freely in accordance with the Boost 1.0 license.

We chose to use Ryu under the Boost Software License and accordingly copied that banner into our sources. (We're pretty careful about isolating derived code into separate source files, especially in product code.)

The important thing for us about the Boost Software License is how it explicitly doesn't require attribution when shipping compiled software to end users, which is something that the LLVM Exception also addresses. (End users don't even know what a C++ Standard Library is.)

As a result, our files implementing and testing <charconv> (although not <charconv> itself, as it's the layer above Ryu) contain both our usual SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception and the (verbose) Boost Software License, both of which must be complied with (which we believe is pretty easy, due to their aligned natures regarding attribution). At the time, I didn't understand that the SPDX syntax wants to express this with AND; see SPDX IDs: How to use.

Again, note the difference: Upstream Ryu is effectively Apache-2.0 OR BSL-1.0 (as it says "Alternatively"). We've chosen the BSL-1.0 option, then added our usual license, so our derived sources are Apache-2.0 WITH LLVM-exception AND BSL-1.0. The OR operator would not be suitable for these derived sources, otherwise further derived code could drop the BSL-1.0.

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Apr 11, 2025
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 11, 2025 08:08
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Apr 11, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Apr 11, 2025
Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not legal advice, but this LGTM 👮

@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in STL Code Reviews Apr 17, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 22, 2025
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 608036c into microsoft:main Apr 22, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 22, 2025
@StephanTLavavej StephanTLavavej deleted the license branch April 22, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

License of xcharconv_ryu.h header

2 participants