Remove mentions of 'fast math' from floating vectorization control #5417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Apr 19, 2025
|
Thanks - I missed that these were editing relics in the original PR #3928. |
StephanTLavavej
changed the title
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Were double quotes used incorrectly? |
|
It was totally fine, I just have to remove double quotes as part of the mirroring process. Instead of doing it internally I just edited the PR title here, which was arguably the wrong thing to do, but it was 3 AM and my brain wasn't braining 😹 |
📜 😸 🪄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #4676 (comment)