-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve search and find_end vectorization
#5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 8 commits into
microsoft:main
from
AlexGuteniev:the-ultimate-search
May 22, 2025
Merged
Improve search and find_end vectorization
#5519
StephanTLavavej
merged 8 commits into
microsoft:main
from
AlexGuteniev:the-ultimate-search
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
May 21, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Population, 9 billion. All SIMD instructions. 🤖 🛸 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two orthogonal but related changes:
searchpath for 8-bit elements (but not forfind_end). Address concern in Vectorizesearchfor 32-bit and 64-bit elements, also improve 8-bit and 16-bit vectorization #5484 (comment)Nothing more to tell about the 8-bit AVX2
searchpath removal. Some details on SSE4,2 path for 32-bit and 64-bit elements:_Sortingor bitset algorithms_Sorting, BSF and BSR are traits members. In_Sorting, these functions were called infrequently, so they were not worth differentiating for AVX2/SSE4.2. Here we use them in tightest loops, so the performance of better ones may make a difference. Beware that CodeQL comments are harder to verify heretzcnt/lzcntwere verified manually._Size_bytes_1is not passed to extracted functions deliberately. In case of non-inline functions it looks more optimal to compute again than to pass 5th parameter and start using stack on x64. in case of inline functions the compiler will combine the same way computed variables if needed.find_endcmpestrmpath, and always usecmpeqinfind_end. The Vectorizesearchfor 32-bit and 64-bit elements, also improve 8-bit and 16-bit vectorization #5484 (comment) results convinced me not to do this, and keep all existing SSE4.2 paths for 8-bit and 16-bit elements