Vectorize equality-comparing algorithms for more types #5527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop _Vector_alg_in_find_first_of_is_safe in favor of _Vector_alg_in_search_is_safe
AlexGuteniev
force-pushed
the
can-of-vectorization
branch
2 times, most recently
from
30600f3 to
14706e0
Compare
AlexGuteniev
force-pushed
the
can-of-vectorization
branch
from
14706e0 to
ab6be2d
Compare
tests/std/tests/GH_000431_equal_memcmp_is_safe/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 20, 2025
|
Thanks! 😻 I fixed typos and pushed minor nitpicks. |
AlexGuteniev
changed the title
equal and ranges::equal using memcmp for more types
|
I've updated the title to a more specific. |
AlexGuteniev
changed the title
equal and ranges::equal using memcmp for more types
Actually, restored previous title. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for supporting Clang as even more of a first-class citizen than MSVC! 😹 🥇 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5479
Use
__is_trivially_equality_comparablestarting in Clang 19, with escape hatch.Distinguish
memcmpand search-like vector algorithms, as the latter need 1, 2, 4, or 8 element size.If this takes on, may improve
mismatchto vectorize for odd element size too.It takes division, but it can be done in the header, where it will be optimized to big multiplication.
Also can look into
_Vector_alg_in_find_is_safe.I'm not sure though:
operator==pair<int, int>orchrono::duration<uint64_t, pico>will not be automatically engaged