Implement P2255R2 Type Traits To Detect References Binding To Temporaries for Clang #5537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
p2255r2-clang
branch
from
4f5e570 to
37ec87a
Compare
frederick-vs-ja
force-pushed
the
p2255r2-clang
branch
from
37ec87a to
3b8a0cb
Compare
Also drop the `__clang_major__ >= 19` guard.
We now always inspect the feature-test macro. (This will change to `_HAS_CXX23` in the future, at which point we'll elide/fuse redundant guards, as we've done many times in the past.)
tests/std/tests/P2255R2_reference_constructs_from_temporary/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2255R2_reference_constructs_from_temporary/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2255R2_tuple_pair_construction/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2255R2_reference_constructs_from_temporary/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Oct 2, 2025
|
Thanks, this is great! 😻 I appreciate the comprehensive test coverage and extreme attention to detail in |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for getting us one step closer to finishing C++23! 😻 🏃 🎉 I've filed #5755 and tracking bugs for MSVC and EDG (after having already emailed them quite some time ago). I resolved #2534 following our usual convention of declaring library victory regardless of whether Clang or MSVC is first to enable library support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2534. (We traditionally resolve features when they've been implemented for at least one of our first-class supported codegen compilers. #5755 tracks getting this implemented for the other one.)
Notes:
allocator_arg_tconstructors oftupleis missing. It seems to me uses-allocator construction is meaningless fortuplecontaining references. I've tried to submit an LWG issue to make theallocator_arg_tconstructors oftuple<Ts...>deleted when(is_reference_v<Ts> || ...)istrue. Edit: LWG-4267.