KEMBAR78
`vector_algorithms.cpp`: Fix zeroupper guard for `is_sorted_until` vectorization by AlexGuteniev · Pull Request #5540 · microsoft/STL · GitHub
Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

  • is_sorted_until is early return algorithm, so it needs scope guard
  • minmax_element and minmax are not early return algorithms, so let their guards stay as direct function call

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner May 24, 2025 13:20
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 24, 2025
@StephanTLavavej StephanTLavavej changed the title vector_algorithms.cpp: Fix zeroupper guard for is_sorted_until vectrorization vector_algorithms.cpp: Fix zeroupper guard for is_sorted_until vectorization May 24, 2025
@StephanTLavavej StephanTLavavej self-assigned this May 27, 2025
@StephanTLavavej StephanTLavavej added the performance Must go faster label May 27, 2025
@StephanTLavavej StephanTLavavej removed their assignment May 27, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews May 27, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews May 28, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 21f7abf into microsoft:main May 28, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews May 28, 2025
@StephanTLavavej
Copy link
Member

💂 🛠️ 😸

@AlexGuteniev AlexGuteniev deleted the is_exit_vectorized branch May 29, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants