KEMBAR78
`<algorithm>`: avoid `continue` in `ranges::includes` by AlexGuteniev · Pull Request #5541 · microsoft/STL · GitHub
Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

Replace continue with chained if.

No performance differences. In fact, no codegen differences expected.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner May 24, 2025 15:13
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 24, 2025
@AlexGuteniev AlexGuteniev changed the title <algorithm>: avoid continue in ranges::includes <algorithm>: avoid continue in ranges::includes May 24, 2025
@StephanTLavavej StephanTLavavej self-assigned this May 27, 2025
@StephanTLavavej StephanTLavavej added enhancement Something can be improved ranges C++20/23 ranges labels May 27, 2025
@StephanTLavavej StephanTLavavej removed their assignment May 27, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews May 27, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews May 28, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1cd875a into microsoft:main May 28, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews May 28, 2025
@StephanTLavavej
Copy link
Member

⛓️ ➡️ ➕

@AlexGuteniev AlexGuteniev deleted the discontinue branch May 29, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved ranges C++20/23 ranges

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants