KEMBAR78
Update `source_location` tests for upcoming EDG changes by StephanTLavavej · Pull Request #5551 · microsoft/STL · GitHub
Skip to content

Conversation

StephanTLavavej
Copy link
Member

EDG is changing their source_location builtins to produce output that more closely resembles C1XX's. To keep our tests passing as these changes are introduced into VS, I'm updating the tests to accept either the old output or the new output. After the changes have shipped and we can update the toolset on GitHub, I can remove the old expected outputs.

@jgoshi has validated that this passes with the upcoming changes.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner May 27, 2025 20:44
@StephanTLavavej StephanTLavavej added the test Related to test code label May 27, 2025
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 27, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews May 27, 2025
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Copy link
Member

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@StephanTLavavej StephanTLavavej moved this from Final Review to Merging in STL Code Reviews May 28, 2025
@StephanTLavavej StephanTLavavej merged commit 7841cf8 into microsoft:main May 28, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews May 28, 2025
@StephanTLavavej StephanTLavavej deleted the horse-location branch May 28, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants