KEMBAR78
`validate.cpp`: report error lines by AlexGuteniev · Pull Request #5559 · microsoft/STL · GitHub
Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

Closes #2349

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner May 31, 2025 11:48
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 31, 2025
@cpplearner

This comment was marked as resolved.

@AlexGuteniev

This comment was marked as resolved.

@AlexGuteniev

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej added enhancement Something can be improved infrastructure Related to repository automation labels Jun 1, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jun 1, 2025
@StephanTLavavej
Copy link
Member

Thanks! 😻 This should make it easier than ever for contributors to find and fix their validation problems.

I pushed a bunch of nitpicks and one enhancement: using the new strategy for disallowed characters. This helps ADO present all errors on the first page, instead of hiding the rest behind more details.

@StephanTLavavej StephanTLavavej removed their assignment Jun 6, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Jun 6, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Jun 11, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4f5c7c8 into microsoft:main Jun 14, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Jun 14, 2025
@StephanTLavavej
Copy link
Member

Thanks for making it easier than ever to conform to the repo's formatting requirements! 😻 📈 🎉

@AlexGuteniev AlexGuteniev deleted the lines branch June 14, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved infrastructure Related to repository automation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

validate.cpp: display line numbers

3 participants