Add missing size_type cast to basic_string
#5562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
string-size-cast
branch
3 times, most recently
from
827aa18 to
1e2a465
Compare
frederick-vs-ja
force-pushed
the
string-size-cast
branch
from
1e2a465 to
64c1f89
Compare
frederick-vs-ja
commented
Jun 9, 2025
| _STD _Seek_wrapped(_First, _STD remove(_STD _Get_unwrapped(_First), _STD _Get_unwrapped(_Last), _Val)); | ||
| _Cont.erase(_First, _Last); | ||
| return _Old_size - _Cont.size(); | ||
| return static_cast<typename _Container::size_type>(_Old_size - _Cont.size()); |
There was a problem hiding this comment.
It seems that _Erase_remove(_if) can be C++20 (and later) -only now, which allows us to drop typename, as we've removed std::experimental::erase(_if).
Merged
StephanTLavavej
approved these changes
Oct 9, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing so many occurrences of warnings! 🛠️ 💯 🐱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5546.
There're some currently problematic cases:
size_typeis narrower thanintand hence usual arithmetic conversion changes the type toint, andsize_typeis 64-bit andsize_tis 32-bit (on a 32-bit platform).Explicit cast will resolve warnings on narrowing and errors with type mismatch in
std::max/std::minin these cases.