<semaphore>: use steady_clock
#5575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Jun 10, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🚦 ⏱️ ⚖️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5574
Abandon
__std_atomic_wait_get_deadlineand__std_atomic_wait_get_remaining_timeout. Originally they were used as fast and convenient steady clock, that is just as precise as the wait itself. But we have to use thesteady_clock, not a steady clock, and be as precise as it is.No need in
_Clamped_rel_time_ms_count. The existing_Semaphore_remaining_timeoutis good enough, although it diverges in that it clamps to 10 days, not to 1 day. Importantly. both usechrono::ceilto get larger rather than smaller timeout when rounding.