Implement LWG-4242 ranges::distance does not work with volatile iterators
#5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
commented
Jun 21, 2025
frederick-vs-ja
force-pushed
the
lwg-4242
branch
from
045d2b8 to
370de5f
Compare
frederick-vs-ja
force-pushed
the
lwg-4242
branch
from
370de5f to
4302333
Compare
24 tasks
StephanTLavavej
requested changes
Jul 23, 2025
github-project-automation
bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
StephanTLavavej
approved these changes
Aug 6, 2025
|
Thanks for filing LWG-4303. This makes it a lot easier to see that the implementation is following what the Standard says, plus a proposed resolution. 😻 |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for handling this highly volatile issue! 🧪 🧑🔬 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per LWG-4242/WG21-P3742R0 (alternative link).
Fixes #5623.
This PR makes the involved overload of
ranges::distancemore constrained than explicitly written, because the "Effects: Equivalent to:" in [range.iter.op.distance]/3 isn't changed and we should propagate the implicit constraints per [structure.specifications]/4.Drive-by change:
ranges::distanceno longer performs such a conversion.