Implement P3503R3 Make Type-Erased Allocator Use In promise And packaged_task Consistent
#5630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/std/tests/P3503R3_packaged_task_promise_with_allocator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P3503R3_packaged_task_promise_with_allocator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P3503R3_packaged_task_promise_with_allocator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P3503R3_packaged_task_promise_with_allocator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P3503R3_packaged_task_promise_with_allocator/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Oct 22, 2025
|
Thanks! 😻 Apologies for taking 4 months to review this. I pushed a minor test fix and various nitpicks. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this C++26 feature interacting with a bunch of old weird tech! 😻 🎉 ⚙️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as a Defect Report against old modes (ideally since C++11). Fixes #5615.
This paper reverts LWG-2921 and supersedes LWG-2976, so I'm removing the corresponding comments from
<yvals_core.h>.The new behavior depends on
dynamic_castdue to ABI compatibility. Old behavior is kept when dynamic RTTI is off.