KEMBAR78
Optimize `_Div_ceil<_Signed128>` by JMazurkiewicz · Pull Request #5637 · microsoft/STL · GitHub
Skip to content

Conversation

JMazurkiewicz
Copy link
Contributor

benchmark before after speedup
bm/div_ceil_int128_uint32 106,54 40,43 2,64
bm/div_ceil_int128_uint64 103,46 40,75 2,54
bm/div_ceil_int128_int128 109,22 43,96 2,48

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner July 2, 2025 11:09
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jul 2, 2025
@JMazurkiewicz JMazurkiewicz changed the title Optimize _Div_ceil Optimize _Div_ceil<_Signed128> Jul 2, 2025
@StephanTLavavej StephanTLavavej added the performance Must go faster label Jul 2, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jul 2, 2025
@StephanTLavavej StephanTLavavej removed their assignment Sep 5, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Sep 5, 2025
@StephanTLavavej
Copy link
Member

Thanks! 😻 I pushed a few simplifications/optimizations, please double-check.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Sep 10, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed

@StephanTLavavej StephanTLavavej merged commit 1a11f5d into microsoft:main Sep 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Sep 10, 2025
@StephanTLavavej
Copy link
Member

Thanks for mathing faster! 🧮 🚀 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

<ranges>: _Div_ceil can be implemented more efficiently for _Signed128 and _Unsigned128

3 participants