Partially implement P3697R1 Minor Additions To Standard Library Hardening #5650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
pre-contract-p3697r1
branch
from
2055f2a to
f466cf6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tests/std/tests/GH_005090_stl_hardening_cxx20_iterators/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005090_stl_hardening_cxx20_iterators/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005090_stl_hardening_cxx20_iterators/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005090_stl_hardening_cxx20_iterators/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 24, 2025
|
Thanks! 😻 I pushed numerous small changes, the only significant one being to |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
💎 💎 💎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes hardening introduced by WG21-P3697R1. Towards #5300.
Hardened preconditions are checked when either
_MSVC_STL_HARDENING_MEOWor_ITERATOR_DEBUG_LEVEL != 0.Notes:
view_interfacewas already hardened in STL Hardening #5274.common_iteratorandcounted_iteratorwere already done, and this PR only makes the checks enabled with hardening options.basic_stacktrace::operator[]is checked by default viavector::operator[], so this PR only enable the additional check when the check ofvector::operator[]is turned off.shared_ptr::operator[],basic_stacktrace::current,common_iterator's constructor,common_iterator::operator==,iter_move(counted_iterator), anditer_swap(counted_iterator)are newly added in this PR.GH_005090_stl_hardening_cxx20_iterators, is added for C++20 (and potentially later) iterators withiter_moveand/oriter_swapbeing hidden friends. These iterators are permanently incompatible with/permissive.