<xloctime>: Silence CodeQL warning SM03231 about leap years, again
#5711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from Ready To Merge
to Done
in STL Code Reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5625. Fixes internal VSO-2566953.
Previously, I silenced "Year field changed using an arithmetic operation without checking for leap year" for all of the locations that were performing arithmetic. Now we've got a new round of warnings, same opaque ID SM03231 but a different message "Field
tm_yearon variable_Pthas been modified, but no appropriate check for LeapYear was found", so we need to suppress every line modifyingtm_year.Once again it's time to quote:
- Ra (Abstract Weapon) by qntm