Fix UB in vector<bool> by adding missing special case
#5726
Conversation
AlexGuteniev
changed the title
vector<bool> by adding missing special case
|
Looks like that the affect statements can be executed in constant execution. Can we add a |
Adding But I'm against a test case for this specific branch. Think that we should be systematic, and make the entire coverage constexpr, except huge and random. And this larger change looks like out of scope, I want to fix specific bug, for which there is already expected ubsan coverage. |
|
Thanks for the quick fix and clear explanation! 😻 |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this UB so quickly! 😻 🛠️ 🛡️ |
3 participants
Fixes #5720.
_IsSingleBlockDesthas special case when that single block touches edge, and_DestEndis greater that_Dest, and_DestEnd._Myoff == 0. This is handled elsewhere:STL/stl/inc/vector
Line 3834 in 43e96b2
STL/stl/inc/vector
Line 3843 in 43e96b2
STL/stl/inc/vector
Line 3860 in 43e96b2
Now we need to add missing handling in the UB causing line. If
_DestEnd._Myoff == 0, we have the only case when the subtraction result is negative. We actually need to subtract from full 32 bits in this case.The UB didn't cause runtime behavior difference, as the shift instruction just ignores high bits.