Block building for the wrong target arch in Developer Command Prompt #5731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpplearner
force-pushed
the
platform-not-defined
branch
from
a92deea to
ecc5ed0
Compare
cpplearner
changed the title
Platform env var is not set in Developer Command Prompt; examine VSCMD_ARG_TGT_ARCH instead
StephanTLavavej
approved these changes
Sep 19, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for noticing that Diablo Canyon 1 wasn't like Diablo Canyon 2! ☢️ 🦅 👁️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4709 and #4717 make it impossible to build in the wrong command prompt (e.g. if someone builds the STL in an "x64 Native Tools Command Prompt" and runs the tests in an "x86 Native Tools Command Prompt"). But they are ineffective in a "Developer Command Prompt" because they examine the
Platformenv var, which is not defined there.This PR examines
VSCMD_ARG_TGT_ARCHinstead, which is defined in both the Developer Command Prompt and the Native Tools Command Prompt.It's unclear to me whether it is safe to use such an undocumented env var. But anyway, if someone encounters an unexpected error, they can just manually unset
VSCMD_ARG_TGT_ARCHwhen building.