vector_algorithms.cpp: Improve conformance by adding missing template and typename for dependent things
#5743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate` and `typename` for dependent things
AlexGuteniev
force-pushed
the
vector-clang-conformance
branch
from
1c108a7 to
7cfff9e
Compare
|
Thanks WG21-P0634R3 for making this only mildly annoying! |
StephanTLavavej
approved these changes
Sep 26, 2025
|
I'm surprised that MSVC doesn't enforce these in strict mode - I think it'd be worth reporting a DevCom bug. |
Reported in 2019
|
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for cleaning up all the broken glass from where MSVC let us be bad kitties, jumping up on the table where we're not allowed and batting objects off! 😹 🐈 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by compiling with
clang-cl stl\src\vector_algorithms.cpp -std:c++latest -march=x86-64-v3.Whereas we don't build STL with that, there are still reason why compiling this particular file with
clang-clmay be useful:-march=x86-64-v3is dropped, there would be a lot of target errors, that are solved by placinggnu::targetattributes. When they are placed expectedly, unexpected instruction on an unverified properly code path will trigger an error.-fsanitize=undefinedto avoid any UB.