KEMBAR78
`vector_algorithms.cpp`: remove unused functions by AlexGuteniev · Pull Request #5744 · microsoft/STL · GitHub
Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Sep 26, 2025

Discovered while experimenting with clang-cl stl\src\vector_algorithms.cpp -std:c++latest command.

A couple of functions are non-unique, and should be removed.

Two other ones are also exiting this file, as scope guard is used instead.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Sep 26, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Sep 26, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Oct 3, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3b1d7d2 into microsoft:main Oct 4, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Oct 4, 2025
@StephanTLavavej
Copy link
Member

🪫 🗑️ 🪄

@AlexGuteniev AlexGuteniev deleted the red-vector branch October 4, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants