KEMBAR78
Final cleanups for `<experimental/filesystem>` by StephanTLavavej · Pull Request #5753 · microsoft/STL · GitHub
Skip to content

Conversation

StephanTLavavej
Copy link
Member

Before I place <experimental/filesystem> into cryostasis, there are a couple of things that I want to clean up, in case we ever need to look at it again while trying to understand legacy code:

  • _FS_DLL => extern "C" _CRTIMP2_PURE
    • This macro obscured how we're dllexporting the separately compiled machinery. Nothing else in the STL used this pattern. It was also never overridden, so the #ifndef _FS_DLL was pointless.
  • _Pchar => wchar_t
    • This alias obscured the path's character type, and wasn't consistently used.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner October 3, 2025 14:40
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 3, 2025
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Oct 3, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Oct 3, 2025
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Copy link
Member

@MahmoudGSaleh MahmoudGSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StephanTLavavej StephanTLavavej moved this from Final Review to Merging in STL Code Reviews Oct 3, 2025
@StephanTLavavej StephanTLavavej merged commit ba64eaa into microsoft:main Oct 4, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Oct 4, 2025
@StephanTLavavej StephanTLavavej deleted the expr-fs branch October 4, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants