KEMBAR78
Cleanups for `<any>` by achabense · Pull Request #5784 · microsoft/STL · GitHub
Skip to content

Conversation

@achabense
Copy link
Contributor

This is mainly a style fix for #3965.

  • To fix self-assignment, that pr introduced an uncommon assignment pattern (_Assign(any-prvalue)), which has caused some maintenance issues. This pr replaces the function with explicit temporary construction and move.
  • Add some precondition checks.

@achabense achabense requested a review from a team as a code owner October 15, 2025 11:17
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Oct 15, 2025
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 15, 2025
@StephanTLavavej StephanTLavavej self-assigned this Oct 15, 2025
@StephanTLavavej
Copy link
Member

Thank you!! 😻 I'm really glad to see the "intentionally pass by value" pattern eliminated.

@StephanTLavavej StephanTLavavej removed their assignment Oct 16, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Oct 16, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Oct 16, 2025
@StephanTLavavej StephanTLavavej merged commit 7f60cfb into microsoft:main Oct 17, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Oct 17, 2025
@StephanTLavavej
Copy link
Member

Thanks for cleaning up anything and everything! 😹 🤪 😺

@achabense achabense deleted the _Any_cleanups branch October 22, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants