KEMBAR78
`<regex>`: Fix `regex_error` when matching a repeated pattern containing a lookahead assertion by muellerj2 · Pull Request #5793 · microsoft/STL · GitHub
Skip to content

Conversation

@muellerj2
Copy link
Contributor

Fixes #5792.

@muellerj2 muellerj2 requested a review from a team as a code owner October 20, 2025 19:25
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Oct 20, 2025
@StephanTLavavej StephanTLavavej added bug Something isn't working regex meow is a substring of homeowner labels Oct 20, 2025
@StephanTLavavej StephanTLavavej self-assigned this Oct 20, 2025
@StephanTLavavej
Copy link
Member

Thanks for fixing this regression and adding test coverage! 🐱

@StephanTLavavej StephanTLavavej removed their assignment Oct 20, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Oct 20, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Oct 22, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

Resolved trivial adjacent-add conflicts with #5790 in tests/std/tests/VSO_0000000_regex_use/test.cpp.

@StephanTLavavej StephanTLavavej merged commit 6a57871 into microsoft:main Oct 22, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Oct 22, 2025
@StephanTLavavej
Copy link
Member

🏚️ 🛠️ 🏡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working regex meow is a substring of homeowner

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

<regex>: regex_match() throws regex_error(error_stack) when a repeated pattern contains a lookahead assertion

2 participants