<ranges>: Make ranges::to support creating unions
#5794
Merged
+69
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union types are also class type in the C++ core language, and [range.utility.conv.adaptors] doesn't exclude them. LWG-4229 attempted to clarify that unions are unsupported, but it's recently set to Tentatively NAD. As a result, we should support creating unions.
StephanTLavavej
approved these changes
Oct 21, 2025
|
Thanks! 😻 I audited all other uses of |
cpplearner
reviewed
Oct 21, 2025
StephanTLavavej
approved these changes
Oct 22, 2025
|
I've pushed a commit to drop "(including union)" as recommended by @cpplearner, and increased the precision of our Standard citations. I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this highly obscure bug! 🐞 🪲 🐝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union types are also class types in the C++ core language, and [range.utility.conv.adaptors] doesn't exclude them.
LWG-4229 attempted to clarify that unions are unsupported, but it's recently set to Tentatively NAD. As a result, we should support creating unions.