Fix GH_001923_filesystem_long_path_support/custombuild.pl for the MSVC-internal test harness #5799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacklj89
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In toolset update #5783 I added test coverage for
<filesystem>long path support. This requires a manifest to be embedded into the executable with a special linker option. The MSVC-internal test harness uses Perl for this, and I used a singleclcommand. It turns out that in certain configurations (of course only run in CI checks, not in PR checks where I would have discovered this earlier), the MSVC-internal test harness adds/FastFailDump. When compiling with Clang, that gets sent to lld-link, which emitsI should have followed precedent and used separate compile and link commands, which avoids confusing lld-link (as in this case I believe we invoke MSVC link.exe):
STL/tests/std/tests/Dev09_056375_locale_cleanup/custombuild.pl
Lines 12 to 13 in 249cb01