Full support for CommonJS auto-imports in JS #37027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
commented
Feb 25, 2020
andrewbranch
commented
Feb 25, 2020
Comment on lines
-173
to
+177
| Equals, | ||
| ConstEquals | ||
| CommonJS, |
There was a problem hiding this comment.
This is the fundamental conceptual change in this file, and everything else is basically just implementation details. This enum used to represent final syntax; now it’s more a representation of where the symbol can be found in the module. Whether or not to use JS is then calculated and stored elsewhere, so that
CommonJScan meanimport foo = require('mod')orconst foo = require('mod')Namespacecan meanimport * as foo from 'mod'orconst foo = require('mod')Defaultcan meanimport foo from 'mod'orconst { default: foo } = require('mod')Namedcan meanimport { foo } from 'mod'orconst { foo } = require('mod')
andrewbranch
requested review from
orta,
sandersn,
sheetalkamat and
weswigham
sandersn
approved these changes
Feb 27, 2020
andrewbranch
commented
Feb 27, 2020
Fix typos Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32684, I added the ability for auto-imports to write a
requirevariable declaration in JS files. However, it didn’t work for named or default exports, and under default project settings, would never be triggered from completions; it was only reachable by code fix. This is particularly problematic for JS, because unless the user has explicitly enabled type checking JS through VS Code settings, a tsconfig or jsconfig file, or// @ts-check, you can’t get code fixes because you don’t get errors.This PR removes those limitations, and also recognizes members of object literals assigned to
module.exportsas importable symbols.How do we choose between
importandrequirefor a JS file?Rules are evaluated in order (highest priority first).
import, add it there.require, add it there.import.require.import.require.How are
requirevariable declarations written for different kinds of exports?const { foo } = require('./foo')maps to named ES exports and CommonJS exported object literal members (module.exports = { foo }).const { default: foo } = require('./foo')maps to default ES exports (hopefully people aren’t actually doing this).const foo = require('./foo')maps to everything else.Fixes #20292
Fixes #30549
Related: