Simplify expression type to fix build break #41942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
ahejlsberg
approved these changes
Dec 12, 2020
There was a problem hiding this comment.
Yeah, that's a nasty little demonstration of exponential growth. It's interesting because the template literal expression that blows up actually only has two possible values. We could perhaps consider a template literal type representation where multiple holes can be marked as having the same origin. Such shared origin holes would be iterated in lockstep when we produce the normalized template literal union type. But for now, we should definitely merge this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the post-LKG build break introduced by the changes in #41891 by simplifying the expression type in use by widening the type of a ternary to
string, rather than a union of literal types.