KEMBAR78
Reducing tsbuildinfo size further by sheetalkamat · Pull Request #43695 · microsoft/TypeScript · GitHub
Skip to content

Reducing tsbuildinfo size further #43695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Retry.
merged 4 commits into from
Apr 17, 2021
Merged

Reducing tsbuildinfo size further #43695

merged 4 commits into from
Apr 17, 2021

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Apr 15, 2021 •
edited
Loading

Here are the numbers with one of the internal tsbuildinfo
4de704d Only emit compiler options that affect

04/15/2021  01:26 PM           670,576 infoNew.json
04/15/2021  01:26 PM         1,023,762 infoOriginal.json

a422f9e: Dont emit affectsGlobalScope if its not true

04/15/2021  01:38 PM           612,256 infoNew.json
04/15/2021  01:38 PM         1,023,762 infoOriginal.json

658587d: FileInfo is encoded as string if FileInfo.version === FileInfo.signature && !FileInfo.affectsGlobalScope, otherwise property signature is encoded as false if it was undefined, undefined if FileInfo.version === FileInfo.signature and actual signature otherwise

04/15/2021  03:47 PM           410,798 infoNew.json
04/15/2021  03:47 PM         1,023,762 infoOriginal.json

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 15, 2021
@sheetalkamat sheetalkamat requested a review from amcasey April 15, 2021 23:14
@sheetalkamat sheetalkamat marked this pull request as ready for review April 15, 2021 23:14
amcasey
amcasey approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just measuring against the motivating code base (ETA one hour).

@amcasey
Copy link
Member

amcasey commented Apr 16, 2021

tsbuildinfo size dropped from 1345MB to 467MB and total build time dropped ~15%. 🎉

sheetalkamat
sheetalkamat commented Apr 16, 2021
View reviewed changes
@sheetalkamat sheetalkamat merged commit 01264ac into master Apr 17, 2021
@sheetalkamat sheetalkamat deleted the tsbuildInfoOptions branch April 17, 2021 06:22
@reverofevil reverofevil mentioned this pull request Jun 17, 2021
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheetalkamat @amcasey @typescript-bot