KEMBAR78
Fix C1010070 compilation error in wslsettings by Mlekow · Pull Request #12928 · microsoft/WSL · GitHub
Skip to content

Fix C1010070 compilation error in wslsettings #12928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix C1010070 compilation error in wslsettings #12928

merged 1 commit into from
Jun 20, 2025

Conversation

@Mlekow
Copy link
Contributor

@Mlekow Mlekow commented May 20, 2025 •
edited
Loading

Summary of the Pull Request

Fixes error c1010070

WSL\out\build\x64-Debug\app.manifest : general error c1010070: Failed to load and parse the manifest.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@benhillis
Copy link
Member

Interesting, I don't see this compiler error. Are you doing anything unique when you see this?

@Mlekow
Copy link
Contributor Author

Mlekow commented May 26, 2025

No unique actions were taken. I'm using Microsoft Visual Studio Professional 2022 (version 17.14.0) with CMake support.

I opened the project via File->Open->CMake. The error occurred while compiling the target wslsettings.

Interesting, I don't see this compiler error. Are you doing anything unique when you see this?

OneBlue
OneBlue approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@OneBlue OneBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the issue if I open the project via VS CMake settings, and I confirmed that the fix works.

LGTM !

@OneBlue OneBlue merged commit dedf361 into microsoft:master Jun 20, 2025
1 check passed
@OneBlue OneBlue mentioned this pull request Jun 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OneBlue OneBlue OneBlue approved these changes

@benhillis benhillis benhillis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mlekow @benhillis @OneBlue