logging: add more settings to vm create begin / end events. #13412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
OneBlue,
craigloewen-msft and
justus-camp-microsoft
benhillis
commented
Aug 20, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
benhillis
force-pushed
the
user/benhill/log_max_processor_count
branch
from
0832c39 to
00157f5
Compare
benhillis
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances VM creation event logging by adding four additional configuration settings to the trace data for better diagnostics. The changes include adding EnableDebugShell, KernelModulesList, MaximumMemorySizeBytes, and MaximumProcessorCount to the telemetry output.
- Updated the CONFIG_TELEMETRY macro to include the new logging fields
- Added a new T_STRING_VECTOR macro for logging vector collections as comma-separated strings
- Fixed naming consistency for LoadKernelModulesPresence variable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/windows/common/WslCoreConfig.h | Updated telemetry macros and CONFIG_TELEMETRY definition to include new fields, fixed variable naming |
| src/windows/common/WslCoreConfig.cpp | Updated variable references to match naming fix and made MaximumProcessorCount a stored field |
benhillis
force-pushed
the
user/benhill/log_max_processor_count
branch
from
faa12c5 to
f7bc9fa
Compare
OneBlue
reviewed
Sep 6, 2025
src/windows/common/WslCoreConfig.cpp
Outdated
| { | ||
| if (!e.empty()) | ||
| { | ||
| kernelModules.emplace_back(e); |
There was a problem hiding this comment.
nit: we could maintain the std::move here to avoid copying e
OneBlue
approved these changes
Sep 6, 2025
benhillis
force-pushed
the
user/benhill/log_max_processor_count
branch
from
f7bc9fa to
5663d3a
Compare
OneBlue
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at some trace data I realized there are some additional VM settings that could be added to improve our diagnostic story. This PR adds the following to the createvm begin / end events: