Implement clean instance terminate when using systemd #13552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
requested review from
OneBlue,
Copilot,
craigloewen-msft and
justus-camp-microsoft
There was a problem hiding this comment.
Pull Request Overview
This PR implements clean instance termination when using systemd by refactoring the termination logic to allow systemd proper time to shut down before falling back to a hard reboot.
- Extracts common termination logic into a new
InitTerminateInstanceInternalfunction - Changes systemd command from
systemctl reboottosystemctl poweroff - Adds timeout waiting for systemd to complete shutdown before forcing reboot
OneBlue
reviewed
Oct 2, 2025
OneBlue
reviewed
Oct 2, 2025
OneBlue
reviewed
Oct 2, 2025
OneBlue
approved these changes
Oct 2, 2025
OneBlue
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that
systemctl poweroffgets time to do its work before terminating the VM.wsl.execommand skips systemd shutdown sequence #13435