Add more verbose output to bsdtar to help root cause 'ImportExportStdout' test failures #13555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out' test failures
…neblue/bsdtar-debug
OneBlue
requested review from
benhillis,
Copilot,
craigloewen-msft and
justus-camp-microsoft
There was a problem hiding this comment.
Pull Request Overview
This PR enhances debugging capabilities for the ImportExportStdout test by adding more verbose output to bsdtar operations. The changes aim to help root cause test failures by providing more detailed logging when debug mode is enabled.
Key Changes
- Added debug logging to identify when the ImportExportStdout test case starts
- Increased bsdtar verbosity from
-vto-vvand added--totalsflag for more detailed output - Updated argument handling to properly support the additional bsdtar flags
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/windows/UnitTests.cpp | Added debug logging to mark the start of ImportExportStdout test case |
| src/windows/service/exe/LxssUserSession.cpp | Enhanced bsdtar verbosity with -vv --totals flags for debug mode |
| src/linux/init/main.cpp | Updated bsdtar argument construction to support enhanced verbosity and totals output |
Comments suppressed due to low confidence (1)
src/linux/init/main.cpp:1
- The
--totalsflag is being inserted at a fixed position (begin() + 3) which assumes the vector structure won't change. This is fragile and could break if the argument order changes. Consider using a more robust approach like inserting before the nullptr terminator or building the arguments conditionally.
/*++
benhillis
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed