Improve logging when socket operations fail #13579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneBlue
requested review from
benhillis,
Copilot,
craigloewen-msft and
justus-camp-microsoft
There was a problem hiding this comment.
Pull Request Overview
This PR improves error logging for socket operations by adding source location information to help diagnose connection and socket-related issues. The changes add std::source_location parameters to socket operation functions to track where errors originate from.
Key Changes:
- Added
std::source_locationparameters to socket operation functions for better error tracking - Created a custom formatter for
std::source_locationto enable logging - Updated error messages to include caller location information
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/windows/service/exe/WslCoreVm.h | Added source_location parameter to AcceptConnection method signature |
| src/windows/service/exe/WslCoreVm.cpp | Updated AcceptConnection implementation to pass location to socket operations |
| src/windows/common/socket.hpp | Added source_location parameters to all socket operation function declarations |
| src/windows/common/socket.cpp | Updated socket functions to accept and use location parameters for enhanced error logging |
| src/windows/common/hvsocket.hpp | Added source_location parameters to Accept and Connect function declarations |
| src/windows/common/hvsocket.cpp | Updated hvsocket functions to pass location information through socket operations |
| src/shared/inc/stringshared.h | Added custom formatter for std::source_location and included source_location header |
| src/linux/init/util.h | Added source_location parameter to UtilConnectVsock function declaration |
| src/linux/init/util.cpp | Enhanced UtilConnectVsock error logging to include caller location information |
2 tasks
benhillis
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This will help diagnose issues like #13301
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed