fix: CodeExecutorAgent prompt misuse #6559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
approved these changes
May 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6559 +/- ##
==========================================
+ Coverage 75.40% 79.52% +4.11%
==========================================
Files 331 225 -106
Lines 19779 16661 -3118
Branches 406 0 -406
==========================================
- Hits 14914 13249 -1665
+ Misses 4592 3412 -1180
+ Partials 273 0 -273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Summary of Change:
The instruction regarding code block format ("Python code should be provided in python code blocks, and sh shell scripts should be provided in sh code blocks for execution") will be moved from
DEFAULT_AGENT_DESCRIPTIONtoDEFAULT_SYSTEM_MESSAGE.Problem Solved:
Ensure that the
model_clientreceives the correct instructions for generating properly formatted code blocks. Previously, the instruction was only included in the agent's description and not passed to the model_client, leading to potential issues in code generation. By moving it toDEFAULT_SYSTEM_MESSAGE, themodel_clientwill now accurately format code blocks, improving the reliability of code generation.Related issue number
Closes #6558
Checks