-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Feat/tool call loop #6651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tool call loop #6651
Conversation
…on guide- Fix version format from 0.4.0-dev-1 to 0.4.0-dev.1 for all packages- Remove reference to non-existent Microsoft.AutoGen.Extensions package- Add correct extension packages: Aspire, MEAI, and SemanticKernel- Fix typo: RuntimeGatewway -> RuntimeGateway- Improve documentation structure with clear section headersFixes #6244
Fix issue #6277 where TextMessage was used but not imported in three code cells of the custom agents documentation, causing NameError when users run the examples. Changes: - Add TextMessage to imports in ArithmeticAgent section - Add TextMessage to imports in GeminiAssistantAgent section - Add TextMessage to imports in Declarative GeminiAssistantAgent section The CountDownAgent section already had the correct import. Fixes #6277
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6651 +/- ##
=======================================
Coverage 79.84% 79.85%
=======================================
Files 232 232
Lines 17513 17540 +27
=======================================
+ Hits 13983 14006 +23
- Misses 3530 3534 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the changes to the dotnet package?
The changes looks very much not ready for review. For example, the tests added are not addressing the tool call loo. I am moving it to the draft state.
If others would like to submit a separate PR for the same issue it's okay too.
Ok , I will make changes and Make it proper. |
…stallation guide- Fix version format from 0.4.0-dev-1 to 0.4.0-dev.1 for all packages- Remove reference to non-existent Microsoft.AutoGen.Extensions package- Add correct extension packages: Aspire, MEAI, and SemanticKernel- Fix typo: RuntimeGatewway -> RuntimeGateway- Improve documentation structure with clear section headersFixes #6244" This reverts commit 6d9fb2e.
…tation" This reverts commit d07898b.
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
…loop_config parameter - Change while loop to for loop for better code readability - Remove reflection flow changes as per reviewer feedback
|
Hello @ekzhu Sir, |
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to further simplify:
- Use a single integer argument "max_tool_call_iteration" defaults to 1.
- Remove changes not related to this addition. Eg to the replay client
Resolved conflicts by: - Merging tool call loop implementation with streaming tool execution - Adding message ID support to tool call loops - Updating imports to include StaticStreamWorkbench and ToolResult - Combining streaming tool execution with existing loop logic - Fixed test conflicts by removing orphaned code The merged implementation preserves both the tool call loop functionality and the streaming capabilities from main branch.
Why are these changes needed?
This PR addresses critical issues in the AssistantAgent that affect tool handling:
Lack of tool call loop functionality: The agent could not perform multiple consecutive tool calls in a single turn, limiting its ability to complete complex multi-step tasks that require chaining tool operations.
These changes enhance the agent's robustness and capability while maintaining full backward compatibility through feature flags.
Related issue number
Closes #6268
Checks