KEMBAR78
add env var to disable runtime tracing by EItanya · Pull Request #6681 · microsoft/autogen · GitHub
Skip to content

Conversation

@EItanya
Copy link
Contributor

@EItanya EItanya commented Jun 16, 2025

Why are these changes needed?

Recently a PR merged to enable GENAI semantic convention tracing, however, when using component loading it's not currently possible to disable the runtime tracing.

This PR allows disabling said tracing using an ENV var

Related issue number

Checks

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the user guide and API doc of SingleThreadedAgentRuntime as well?

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (89927ca) to head (79f07ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...togen-core/src/autogen_core/_telemetry/_tracing.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6681      +/-   ##
==========================================
- Coverage   79.71%   79.70%   -0.02%     
==========================================
  Files         232      232              
  Lines       17323    17329       +6     
==========================================
+ Hits        13809    13812       +3     
- Misses       3514     3517       +3     
Flag Coverage Δ
unittests 79.70% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

EItanya added 2 commits June 18, 2025 12:43
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
@EItanya
Copy link
Contributor Author

EItanya commented Jun 18, 2025

hey @ekzhu, I fixed mypy

@ekzhu ekzhu merged commit c5b893d into microsoft:main Jun 20, 2025
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants