Fix mutable default in ListMemoryConfig #6729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…430514/Downloads/autogen/python/packages/autogen-core/src/autogen_core/memory/_list_memory.py:12:0-18:65) [ListMemoryConfig](cci:2://file:///c:/Users/T2430514/Downloads/autogen/python/packages/autogen-core/src/autogen_core/memory/_list_memory.py:12:0-18:65) used a shared empty list (`memory_contents: List[MemoryContent] = []`) as its default, causing every [ListMemory](cci:2://file:///c:/Users/T2430514/Downloads/autogen/python/packages/autogen-core/src/autogen_core/memory/_list_memory.py:21:0-171:79) instance to share the same underlying list. This unexpected state leakage let memories written in one instance silently surface in others, breaking isolation and leading to hard-to-reproduce bugs. Replaced the mutable default with a safe Pydantic `Field(default_factory=list)`, ensuring each configuration—and thus each [ListMemory](cci:2://file:///c:/Users/T2430514/Downloads/autogen/python/packages/autogen-core/src/autogen_core/memory/_list_memory.py:21:0-171:79)—gets its own independent list Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
Fix mutable default in ListMemoryConfig
ekzhu
approved these changes
Jun 29, 2025
|
@mohiuddin-khan-shiam please check our Python developer guide: python/README.md for formatting and running local checks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6729 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 232 232
Lines 17513 17513
=======================================
Hits 13983 13983
Misses 3530 3530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mutable default in ListMemoryConfig
ListMemoryConfig used a shared empty list (
memory_contents: List[MemoryContent] = []) as its default, causing every ListMemory instance to share the same underlying list. This unexpected state leakage let memories written in one instance silently surface in others, breaking isolation and leading to hard-to-reproduce bugs.Replaced the mutable default with a safe Pydantic
Field(default_factory=list), ensuring each configuration—and thus each ListMemory—gets its own independent list.