-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Adds Redis Memory extension class #6743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Redis Memory extension class #6743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. A couple of things:
- Let's use the module path
autogen_ext.memory.redisfor the new module. - Add API doc to
RedisMemorywith examples of usage. Make sure the code blocks are checked by pyright, the CI checks the formatting and types of API docs. Seepython/README.mdfor information on checks. Many users use the API Reference directly. - In the usage guide notebook, can you simplify the setup instructions for the redis example. The example should just refer to the API doc using reference:
{py:class}`~autogen_ext.memory.redisvl.RedisMemory`
f309dd0 to
dabb01c
Compare
|
@ekzhu thanks for the review, it's really appreciated. |
|
@microsoft-github-policy-service agree company="Redis" |
python/packages/autogen-ext/src/autogen_ext/memory/redis/_redis_memory.py
Outdated
Show resolved
Hide resolved
…k/autogen into feature/add-redis-memory
…k/autogen into feature/add-redis-memory
|
@tylerhutcherson if you want to follow along with this PR. |
|
Looks like there are a lot of test failures. |
Hey @ekzhu stepping in for @justin-cechmanek to help get us over the finish line here. We are looking into the failures. Looks like part of the issue was a uv.lock update. Can you try rerunning them again? We will dig to see what parts of our code and tests touch these suites. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6743 +/- ##
==========================================
- Coverage 79.92% 79.91% -0.01%
==========================================
Files 233 235 +2
Lines 18108 18172 +64
==========================================
+ Hits 14473 14523 +50
- Misses 3635 3649 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why are these changes needed?
This PR adds the RedisMemory class to allow for developers to use Redis vector search for agent memory. Redis vector db offers a persistent store and the ability to semantically search for relevant memories.
Related issue number
None
Checks