KEMBAR78
Adds Redis Memory extension class by justin-cechmanek · Pull Request #6743 · microsoft/autogen · GitHub
Skip to content

Conversation

@justin-cechmanek
Copy link
Contributor

Why are these changes needed?

This PR adds the RedisMemory class to allow for developers to use Redis vector search for agent memory. Redis vector db offers a persistent store and the ability to semantically search for relevant memories.

Related issue number

None

Checks

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A couple of things:

  1. Let's use the module path autogen_ext.memory.redis for the new module.
  2. Add API doc to RedisMemory with examples of usage. Make sure the code blocks are checked by pyright, the CI checks the formatting and types of API docs. See python/README.md for information on checks. Many users use the API Reference directly.
  3. In the usage guide notebook, can you simplify the setup instructions for the redis example. The example should just refer to the API doc using reference:
{py:class}`~autogen_ext.memory.redisvl.RedisMemory`

@justin-cechmanek justin-cechmanek force-pushed the feature/add-redis-memory branch from f309dd0 to dabb01c Compare July 9, 2025 23:12
@justin-cechmanek
Copy link
Contributor Author

@ekzhu thanks for the review, it's really appreciated.
Are there any other things you would like me to address?

@justin-cechmanek justin-cechmanek requested a review from ekzhu July 11, 2025 22:02
@justin-cechmanek
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Redis"

@justin-cechmanek
Copy link
Contributor Author

@tylerhutcherson if you want to follow along with this PR.

@justin-cechmanek justin-cechmanek requested a review from ekzhu July 22, 2025 20:44
@ekzhu
Copy link
Collaborator

ekzhu commented Jul 24, 2025

Looks like there are a lot of test failures.

@tylerhutcherson
Copy link

tylerhutcherson commented Jul 24, 2025

Looks like there are a lot of test failures.

Hey @ekzhu stepping in for @justin-cechmanek to help get us over the finish line here. We are looking into the failures. Looks like part of the issue was a uv.lock update.

Can you try rerunning them again? We will dig to see what parts of our code and tests touch these suites.

@codecov
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.91%. Comparing base (e26bb1c) to head (e475064).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-ext/src/autogen_ext/memory/redis/_redis_memory.py 77.41% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6743      +/-   ##
==========================================
- Coverage   79.92%   79.91%   -0.01%     
==========================================
  Files         233      235       +2     
  Lines       18108    18172      +64     
==========================================
+ Hits        14473    14523      +50     
- Misses       3635     3649      +14     
Flag Coverage Δ
unittests 79.91% <78.12%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu merged commit 3b139c6 into microsoft:main Jul 26, 2025
69 of 70 checks passed
@justin-cechmanek justin-cechmanek deleted the feature/add-redis-memory branch July 28, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants