fix: Add proper serialization to RedisStore for complex objects #6905
+190
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6905 +/- ##
==========================================
- Coverage 81.00% 80.89% -0.11%
==========================================
Files 237 237
Lines 18329 18349 +20
==========================================
- Hits 14847 14844 -3
- Misses 3482 3505 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ekzhu
reviewed
Aug 11, 2025
python/packages/autogen-ext/src/autogen_ext/cache_store/redis.py
Outdated
Show resolved
Hide resolved
|
@biradrags pls review to see if this addresses your issue, thx. |
biradrags
reviewed
Aug 11, 2025
python/packages/autogen-ext/src/autogen_ext/cache_store/redis.py
Outdated
Show resolved
Hide resolved
biradrags
approved these changes
Aug 11, 2025
ekzhu
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The RedisStore implementation currently doesn't properly handle serialization of complex objects like Pydantic models, causing ChatCompletionCache to fail when used with RedisStore. This PR fixes the issue by adding proper JSON serialization and deserialization while maintaining backward compatibility for primitive types.
Related issue number
Closes #6899
Checks