-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Update OpenAIAgent to reflect gap in supporting custom function tool #6943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tejas-dharani I have removed custom tools from OpenAIAgent as it is not currently implemented properly. |
|
It doesn't seem unreachable to grab code from the Assistants API agent and carry over it in the Responses API agent? |
Would love to get help with that :) For now I would like to make a release to fix various bugs related to the OpenAIAgent's validation code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6943 +/- ##
==========================================
+ Coverage 80.80% 80.97% +0.17%
==========================================
Files 237 237
Lines 18351 18148 -203
==========================================
- Hits 14829 14696 -133
+ Misses 3522 3452 -70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
re: fixing various bugs - fully support, just please don't do that in the same commit as removal (if you really want to remove) the function tool population code so that it can be reverted easily if needed. Otherwise I'd love to help with the proper function support however I'll be able to address this no earlier than this weekend, I'm not familiar with the code yet. |
We can always go back to the older commit for pieces that we need, right? However, what I have seen is that the code behind OpenAIAgent likely needs a big refactor to make it work like the |
Resolves: #6937