KEMBAR78
Update OpenAIAgent to reflect gap in supporting custom function tool by ekzhu · Pull Request #6943 · microsoft/autogen · GitHub
Skip to content

Conversation

@ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Aug 19, 2025

Resolves: #6937

@ekzhu ekzhu changed the title Update oai agent Fix OpenAIAgent custom function tool calls Aug 19, 2025
@ekzhu ekzhu changed the title Fix OpenAIAgent custom function tool calls Update OpenAIAgent to reflect gap in supporting custom function tool Aug 19, 2025
@ekzhu
Copy link
Collaborator Author

ekzhu commented Aug 19, 2025

@tejas-dharani I have removed custom tools from OpenAIAgent as it is not currently implemented properly.

@ekzhu ekzhu enabled auto-merge (squash) August 19, 2025 06:45
@ekzhu ekzhu disabled auto-merge August 19, 2025 06:45
@alexey-pelykh
Copy link
Contributor

It doesn't seem unreachable to grab code from the Assistants API agent and carry over it in the Responses API agent?

@ekzhu
Copy link
Collaborator Author

ekzhu commented Aug 19, 2025

It doesn't seem unreachable to grab code from the Assistants API agent and carry over it in the Responses API agent?

Would love to get help with that :)

For now I would like to make a release to fix various bugs related to the OpenAIAgent's validation code

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.97%. Comparing base (fbc7888) to head (868e2ab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6943      +/-   ##
==========================================
+ Coverage   80.80%   80.97%   +0.17%     
==========================================
  Files         237      237              
  Lines       18351    18148     -203     
==========================================
- Hits        14829    14696     -133     
+ Misses       3522     3452      -70     
Flag Coverage Δ
unittests 80.97% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexey-pelykh
Copy link
Contributor

re: fixing various bugs - fully support, just please don't do that in the same commit as removal (if you really want to remove) the function tool population code so that it can be reverted easily if needed.

Otherwise I'd love to help with the proper function support however I'll be able to address this no earlier than this weekend, I'm not familiar with the code yet.

@ekzhu
Copy link
Collaborator Author

ekzhu commented Aug 19, 2025

re: fixing various bugs - fully support, just please don't do that in the same commit as removal (if you really want to remove) the function tool population code so that it can be reverted easily if needed.

We can always go back to the older commit for pieces that we need, right? However, what I have seen is that the code behind OpenAIAgent likely needs a big refactor to make it work like the OpenAIAssistantAgent. So it's probably better to start with a clean slate.

@ekzhu ekzhu merged commit d4dd4a2 into main Aug 19, 2025
74 checks passed
@ekzhu ekzhu deleted the ekzhu-fix-oaiagent branch August 19, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAIAgent should support function tools

2 participants