Add security warnings and default to DockerCommandLineCodeExecutor #7035
+111
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances security by: 1. **Default to DockerCommandLineCodeExecutor**: Added create_default_code_executor() function that prefers Docker when available, falling back to Local with warnings 2. **LocalCommandLineCodeExecutor warnings**: Added security warning when LocalCommandLineCodeExecutor is instantiated directly, recommending Docker instead 3. **CodeExecutorAgent approval warnings**: Added warning when no approval_func is set, encouraging human oversight for code execution 4. **Centralized logic**: Created shared utility in autogen_ext.code_executors for consistent default executor behavior across the codebase 5. **Updated MagenticOne**: Refactored to use the shared default executor logic while maintaining backward compatibility 6. **Test compatibility**: Updated test mocks to work with the new structure 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7035 +/- ##
==========================================
+ Coverage 80.95% 81.08% +0.13%
==========================================
Files 237 238 +1
Lines 18258 18271 +13
==========================================
+ Hits 14780 14815 +35
+ Misses 3478 3456 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances security by:
Default to DockerCommandLineCodeExecutor: Added create_default_code_executor()
function that prefers Docker when available, falling back to Local with warnings
LocalCommandLineCodeExecutor warnings: Added security warning when
LocalCommandLineCodeExecutor is instantiated directly, recommending Docker instead
CodeExecutorAgent approval warnings: Added warning when no approval_func
is set, encouraging human oversight for code execution
Centralized logic: Created shared utility in autogen_ext.code_executors
for consistent default executor behavior across the codebase
Updated MagenticOne: Refactored to use the shared default executor logic
while maintaining backward compatibility
Test compatibility: Updated test mocks to work with the new structure
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Why are these changes needed?
Related issue number
Checks