add a BreakpointMode for different types of breakpoints #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkistm
reviewed
Feb 12, 2024
debugAdapterProtocol.json
Outdated
| "breakpointModes": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/ChecksumAlgorithm" |
There was a problem hiding this comment.
Should it be #/definitions/BreakpointMode instead?
|
Same suggestion as from the issue: I think we should add this to all of the breakpoint requests (missing: |
|
PR Updated. |
|
LGTM |
roblourens
reviewed
Feb 14, 2024
|
|
||
| /** | ||
| * A help text providing additional information about the breakpoint mode. | ||
| * This string is typically shown as a hover and can be translated. |
There was a problem hiding this comment.
'label' could be translated too, right? Do we normally call this out?
roblourens
reviewed
Feb 14, 2024
| "items": { | ||
| "$ref": "#/definitions/BreakpointModeApplicability" | ||
| }, | ||
| "description": "Describes one or more type of breakpoint this mode applies to." |
There was a problem hiding this comment.
Suggested change
| "description": "Describes one or more type of breakpoint this mode applies to." | |
| "description": "Describes one or more types of breakpoints this mode applies to." |
roblourens
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #454