KEMBAR78
pydevd: Fix up prefix of attach shared library for Windows by osiewicz · Pull Request #1939 · microsoft/debugpy · GitHub
Skip to content

Conversation

osiewicz
Copy link
Contributor

@osiewicz osiewicz commented Aug 5, 2025

Follow-up to #1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)

Follow-up to microsoft#1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)
@osiewicz osiewicz requested a review from a team as a code owner August 5, 2025 17:06
Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this wasn't caught in any of the tests? Shouldn't an attach test have been failing?

@rchiodo
Copy link
Contributor

rchiodo commented Aug 5, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@osiewicz
Copy link
Contributor Author

osiewicz commented Aug 5, 2025

That I don't know, but there were some CI failures in #1917. Whether that's relevant - I'm not sure.
https://github.com/microsoft/debugpy/runs/44871322864

@rchiodo
Copy link
Contributor

rchiodo commented Aug 5, 2025

Hmm, not sure why but either works for me locally. Oh no wait, it's only a problem on 3.11 and earlier. Sys monitoring doesn't use this method.

Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I verified this change is required for attach in 3.11 and below on Windows.

Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I verified this change is required for attach in 3.11 and below on Windows.

@osiewicz
Copy link
Contributor Author

osiewicz commented Aug 5, 2025

Thanks for a quick turnaround - and sorry for messing up. A member of our community told me VSC's Python plugin is not using latest version of Debugpy just yet, so hopefully it won't have any consequences.

@rchiodo rchiodo merged commit b00a812 into microsoft:main Aug 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants