-
Notifications
You must be signed in to change notification settings - Fork 175
pydevd: Fix up prefix of attach shared library for Windows #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Follow-up to microsoft#1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why this wasn't caught in any of the tests? Shouldn't an attach test have been failing?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
That I don't know, but there were some CI failures in #1917. Whether that's relevant - I'm not sure. |
|
Hmm, not sure why but either works for me locally. Oh no wait, it's only a problem on 3.11 and earlier. Sys monitoring doesn't use this method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I verified this change is required for attach in 3.11 and below on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I verified this change is required for attach in 3.11 and below on Windows.
|
Thanks for a quick turnaround - and sorry for messing up. A member of our community told me VSC's Python plugin is not using latest version of Debugpy just yet, so hopefully it won't have any consequences. |
Follow-up to #1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)