-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Closed
Labels
debugDebug viewlet, configurations, breakpoints, adapter issuesDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiderson-release-notesIssue/pull request mentioned in release notesIssue/pull request mentioned in release notesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
From #102493 (comment)
In this case:
- The user had Node.js importing a different casing of their file (
socks5udp) than what was actually on their disk (socks5UDP).
{
"source": {
"name": "socks5UDP.js",
"path": "c:\\Users\\Rohit Kapoor\\source\\sockem\\lib\\socks5UDP.js"
},
- They set breakpoints, VS Code set in
socks5UDP - We set the breakpoint, and V8 resolved it. V8 used the imported casing
socks5udp - Then js-debug sent back that the breakpoint in the source, using the casing/path from Chrome
{
"name": "lib/socks5udp.js",
"path": "c:\\Users\\Rohit Kapoor\\source\\sockem\\lib\\socks5udp.js",
"sourceReference": 0
}
- This caused the breakpoint to move out of its correct file in VS Code
What should be the proper behavior here? Who should canonicalize the path?
Metadata
Metadata
Assignees
Labels
debugDebug viewlet, configurations, breakpoints, adapter issuesDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insiderson-release-notesIssue/pull request mentioned in release notesIssue/pull request mentioned in release notesverification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded