-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Open
Labels
commentsComments Provider/Widget/Panel issuesComments Provider/Widget/Panel issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalitynotebook
Milestone
Description
We will explore how to bring the commenting experience from the monaco editor to the notebook land.
- Extend comment controller to support notebook document
- Current comment controller support creating comments on a text document range, we need
CommentController/CommentThreadfor notebook ranges CommentRangeProvidershould also support notebook document if it's still neededReactionHandlerhas no dependencies on text document range, so it doesn't need to be updated
- Current comment controller support creating comments on a text document range, we need
- Current
CommentThreadWidgetin the core is a monaco editorViewZoneinstance. It is tied toViewZone's lifecyle and event handers. We want to extract it to a common widget and share it with notebook editor. - The new
CommentThreadWidgetcan be rendered as aCellPartbut it might have performance issue.ViewZones in monaco editor doesn't do virtualization so it's not affected by the slow/costly creation.- Another approach is adding a new layer in notebook list, similar to the
ViewZonelayer in Monaco Editor. TheCommentThreadWidgetcan be absolutely positioned in this layer. The comments then will not be treated as parts of aCell.
- Another approach is adding a new layer in notebook list, similar to the
rehmsenLemmingh
Metadata
Metadata
Labels
commentsComments Provider/Widget/Panel issuesComments Provider/Widget/Panel issuesfeature-requestRequest for new features or functionalityRequest for new features or functionalitynotebook