KEMBAR78
Scroll top improvement based on context · Issue #169038 · microsoft/vscode · GitHub
Skip to content

Scroll top improvement based on context #169038

@rebornix

Description

@rebornix

Currently the scroll top position update is not context-aware, meaning when we have cell height changes, we don't know if it's because output height change, or users re-run a cell and outputs are updated/replaced, or users shift+enter to run cell and navigate to next cell. Users might have different expectations for each scenario but currently our heuristics for updating the scroll top didn't take the context into account.

Let's use this issue to finalize the desired behavior of scroll top update. The polished/new design should cover

  • Update element height API respects context (execution, execute+create, output update)
  • Reveal API should handle out of sync view/content height

Execute focused cell

  • Click the run button or press Ctrl+Enter to run focused cell
  • If there is no enough room/space after the cell (e.g., the focused cell is the last cell)
    • Users have editor.scrollBeyondLastLine disabled
    • Users have editor.scrollBeyondLastLine enabled
      • Reveal cell output
  • If there is enough room after the cell
    • Reveal cell output
  • If the cell input is larger than the viewport, execute cell should reveal the output properly Disable auto scrolling when executing cell. #129440

Operations on focused cell

Operations on non-focused cell

Split view

Metadata

Metadata

Assignees

Labels

insiders-releasedPatch has been released in VS Code Insidersnotebook-layoutplan-itemVS Code - planned item for upcomingunder-discussionIssue is under discussion for relevance, priority, approach

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions