KEMBAR78
Introduce NotebookDocumentChangeEvent#reason · Issue #212063 · microsoft/vscode · GitHub
Skip to content

Introduce NotebookDocumentChangeEvent#reason  #212063

@rebornix

Description

@rebornix

Had a discussion with @dbaeumer and learnt that adding reason was perhaps not sufficient or not what was required.
Salient points of the meeting:

  • Existing event is unfortunately a little complex and difficult to use/understand, as this event can be triggered for a number of reasons related to notebook content and notebook execution state changes.
    • Hence consumers will likely make assumptions when consuming this event.
  • When consuming this event (at least in the case of LSP)
    • Difficult to understand the current execution state (starting, executing, stopped, etc)
    • Are changes a result of execution or other

A follow up discussion will be required with @dbaeumer and a few others to some of the above issues (& possibly others, if any) are addressed

For #211142

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions