-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Closed
Labels
tasksTask system issuesTask system issuesunder-discussionIssue is under discussion for relevance, priority, approachIssue is under discussion for relevance, priority, approach
Milestone
Description
Both tasks ShellTask and TerminalTask use a happy mix of readonly, xyz | undefined type declarations, and non JS-ish defaults. I'd recommend to clarify things, e.g
- Use question mark for types that can be undefined, e.g
CompletionItem#insertText - Don't use
readonlythe model is anyway that VS Code created a disconnected copy of that data providers return - Don't use empty defaults like an empty array or empty object. The JavaScript programmer expects
undefined
Metadata
Metadata
Assignees
Labels
tasksTask system issuesTask system issuesunder-discussionIssue is under discussion for relevance, priority, approachIssue is under discussion for relevance, priority, approach