-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Closed
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersmenusMenu items and widget issuesMenu items and widget issues
Milestone
Description
PR #97965 fixes issues with maintaining focus inside a dom element when the context view is opened. However, by rendering as a child of other DOM elements we risk unintended DOM interaction via css or otherwise. As a workaround for now, this has been scoped to a handful of widgets that need the behavior change. Now we have debt that we should invest in making the context view a shadow dom node that has all of its css injected to avoid unintended interaction.
/cc @joaomoreno
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersmenusMenu items and widget issuesMenu items and widget issues