-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Show filtered stats #107067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show filtered stats #107067
Conversation
Use fixed size when pane grows instead of flex to avoid flickering
|
Hi @isidorn |
|
@pfongkye thanks a lot for this PR. I will review it in detail and test it out tomorrow |
|
@pfongkye thanks for your PR, I tried it out and seems to work good. Here's my feedback:
Thanks! |
|
@isidorn |
|
Great thanks. Just ping me once it is ready for review again. |
This reverts commit d660621.
|
Looks great! Merging in and I will push some polish commits on top of this work. |
|
Pushed some minor improvements via a47bf98 |
@isidorn I like the refactoring since it's cleaner now. However, I noticed that a scenario might have been left out. When you pause the debugger and begin to type in the filter, the badge will be updated. However, if you hit continue on the debugger, the badge will not be updated, |
This PR fixes #105866